Skip to content

Update release_notes_check.py#431

Merged
nrichers merged 1 commit intomainfrom
nrichers-patch-1
Oct 9, 2025
Merged

Update release_notes_check.py#431
nrichers merged 1 commit intomainfrom
nrichers-patch-1

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented Oct 8, 2025

Pull Request Description

What and why?

This PR fixes the outdated auth warning that is causing workflow issues.

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@nrichers nrichers added the internal Not to be externalized in the release notes label Oct 8, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

PR Summary

This PR updates the authentication method used in the release notes check script. The previous approach initialized the Github API client using only the access token. The updated code now creates an authentication object using the token and passes it to the Github client constructor. This change follows best practices recommended by the Github library, ensuring better security and clearer authentication code structure. Only functional changes have been applied, with no alterations to non-critical files.

Test Suggestions

  • Test the script with a valid GitHub access token to ensure that the authentication process is working correctly.
  • Verify that the script correctly fetches the repository and pull request details after the changes.
  • Simulate an invalid or expired token scenario to test error handling and user feedback.

@nrichers nrichers merged commit 572d040 into main Oct 9, 2025
9 of 10 checks passed
@nrichers nrichers deleted the nrichers-patch-1 branch October 9, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants